Skip to content

Update target.bzl to remove a comment#19380

Merged
psiddh merged 1 commit intomainfrom
psiddh-patch-3
May 7, 2026
Merged

Update target.bzl to remove a comment#19380
psiddh merged 1 commit intomainfrom
psiddh-patch-3

Conversation

@psiddh
Copy link
Copy Markdown
Contributor

@psiddh psiddh commented May 7, 2026 •
edited
Loading

This is an interim fix, as the follow up diffs will enable this flag to sync internal states

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

@psiddh
Update target.bzl to remove a comment
71279f7 
This is an interim fix, as the follow up diffs will enable this flag
@psiddh psiddh requested a review from Gasoonjia May 7, 2026 23:20
@psiddh psiddh requested a review from digantdesai as a code owner May 7, 2026 23:20
Copilot AI review requested due to automatic review settings May 7, 2026 23:20
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 7, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19380

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 288 Pending

As of commit 71279f7 with merge base fa857bd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 7, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels May 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI reviewed May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an inline explanatory comment from the Arm backend Bazel test target configuration, leaving the _ENABLE_VGF flag definition unchanged.

Changes:

  • Removed the trailing comment explaining why _ENABLE_VGF is disabled in backends/arm/test/targets.bzl.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@psiddh psiddh merged commit 91aef57 into main May 7, 2026
439 of 443 checks passed
@psiddh psiddh deleted the psiddh-patch-3 branch May 7, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@kirklandsign kirklandsign kirklandsign approved these changes

@Gasoonjia Gasoonjia Awaiting requested review from Gasoonjia

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@psiddh @kirklandsign